Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fixing field context examples #76887

Conversation

lockewritesdocs
Copy link
Contributor

@lockewritesdocs lockewritesdocs commented Aug 24, 2021

Updates the examples for the Painless field context and also modifies the context examples so that all actors are lists.

Preview link: https://elasticsearch_76887.docs-preview.app.elstc.co/guide/en/elasticsearch/painless/master/painless-field-context.html

Resolves #76799

@lockewritesdocs lockewritesdocs added >docs General docs changes :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.0.0 v7.14.1 v7.15.0 labels Aug 24, 2021
@lockewritesdocs lockewritesdocs self-assigned this Aug 24, 2021
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Core/Infra Meta label for core/infra team labels Aug 24, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@lockewritesdocs lockewritesdocs mentioned this pull request Aug 24, 2021
@lockewritesdocs lockewritesdocs added the auto-backport Automatically create backport pull requests when merged label Aug 24, 2021
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor comment.

}
},
"number-of-actors": {
"script": {
"source": "params['_source']['actors'].size()"
"source": "doc['actors'].size()"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stu-elastic Just wanted to confirm this is as expected.

Copy link
Contributor

@stu-elastic stu-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lockewritesdocs lockewritesdocs merged commit 56efbd8 into elastic:master Aug 24, 2021
@lockewritesdocs lockewritesdocs deleted the docs__fix-painless-field-example branch August 24, 2021 18:10
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
7.14
7.15

lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Aug 24, 2021
lockewritesdocs pushed a commit that referenced this pull request Aug 24, 2021
* [DOCS] Fixing field context examples (#76887)

* Add doc type for 7.x
lockewritesdocs pushed a commit that referenced this pull request Aug 24, 2021
* [DOCS] Fixing field context examples (#76887)

* Add doc type for 7.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes Team:Core/Infra Meta label for core/infra team Team:Docs Meta label for docs team v7.14.1 v7.15.0 v8.0.0-alpha2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants