Document transport.compress trade-offs more clearly
#108458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaveCTurner
added
>docs
|
Documentation preview: |
DaveCTurner
force-pushed
the
2024/05/09/transport.compress-tradeoffs
branch
2 times, most recently
from
2de68ac
to
f9e28b9
Compare
Spells out explicitly that setting `transport.compress: true` may cost extra CPU.
DaveCTurner
force-pushed
the
2024/05/09/transport.compress-tradeoffs
branch
from
f9e28b9
to
9d1338f
Compare
elasticsearchmachine
added
Team:Distributed
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-distributed (Team:Distributed) |
Tim-Brooks
approved these changes
May 9, 2024
| compression by to the `transport.compress` setting. Accepts either `deflate` or | ||
| `lz4`, which offer different trade-offs between compression ratio and CPU | ||
| usage. {es} will use the same compression scheme for responses as for the | ||
| corresponding requests. If `lz4` is configured and the remote node has not been | ||
| upgraded to a version supporting `lz4`, the traffic will be sent uncompressed. |
There was a problem hiding this comment.
LZ4 was added in V_7_14_0 which cannot communicate on non-handshake requests with current version nodes. So I don't think we need to document this fallback behavior anymore?
There was a problem hiding this comment.
Ah right good point, I did wonder whether that was obsolete.
DaveCTurner
added
auto-merge
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 9, 2024
Spells out explicitly that setting `transport.compress: true` may cost extra CPU.
💔 Backport failed
You can use sqren/backport to manually backport by running |
DaveCTurner
added a commit
that referenced
this pull request
May 13, 2024
Spells out explicitly that setting `transport.compress: true` may cost extra CPU.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spells out explicitly that setting
transport.compress: truemay costextra CPU.