Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify docs on deleting searchable snapshots #108451

Conversation

DaveCTurner
Copy link
Contributor

The word cannot implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see #73947). This
commit clarifies this by saying must not instead.

Closes #108450

The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see elastic#73947). This
commit clarifies this by saying `must not` instead.

Closes elastic#108450
@DaveCTurner DaveCTurner added >docs General docs changes :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.14.1 v8.15.0 v8.13.5 labels May 9, 2024
@DaveCTurner DaveCTurner requested a review from kingherc May 9, 2024 09:18
Copy link

github-actions bot commented May 9, 2024

Documentation preview:

@elasticsearchmachine elasticsearchmachine added Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team labels May 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Contributor

@kingherc kingherc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DaveCTurner DaveCTurner added the auto-backport-and-merge Automatically create backport pull requests and merge when ready label May 9, 2024
@DaveCTurner DaveCTurner merged commit 91bed34 into elastic:main May 9, 2024
6 checks passed
@DaveCTurner DaveCTurner deleted the 2024/05/09/searchable-snapshots-must-not-delete branch May 9, 2024 17:37
DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 9, 2024
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see elastic#73947). This
commit clarifies this by saying `must not` instead.

Closes elastic#108450
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.14
8.13

DaveCTurner added a commit to DaveCTurner/elasticsearch that referenced this pull request May 9, 2024
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see elastic#73947). This
commit clarifies this by saying `must not` instead.

Closes elastic#108450
elasticsearchmachine pushed a commit that referenced this pull request May 9, 2024
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see #73947). This
commit clarifies this by saying `must not` instead.

Closes #108450
elasticsearchmachine pushed a commit that referenced this pull request May 9, 2024
The word `cannot` implies Elasticsearch prevents you from doing these
things, but it doesn't have this protection today (see #73947). This
commit clarifies this by saying `must not` instead.

Closes #108450
kunisen added a commit that referenced this pull request May 17, 2024
Update searchable snapshot to clarify it's not a backup of index data and deleting it will result in permanent data loss. 

It's a follow up of #108451
DaveCTurner added a commit that referenced this pull request May 17, 2024
Relates #108451

Co-authored-by: David Turner <david.turner@elastic.co>
DaveCTurner added a commit that referenced this pull request May 17, 2024
Relates #108451

Co-authored-by: David Turner <david.turner@elastic.co>
DaveCTurner added a commit that referenced this pull request May 17, 2024
Relates #108451

Co-authored-by: David Turner <david.turner@elastic.co>
parkertimmins pushed a commit to parkertimmins/elasticsearch that referenced this pull request May 17, 2024
Relates elastic#108451

Co-authored-by: David Turner <david.turner@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes Team:Distributed Meta label for distributed team Team:Docs Meta label for docs team v8.13.5 v8.14.1 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Searchable snapshot should not be able to be deleted if it's in use by a frozen index
3 participants