New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify docs on deleting searchable snapshots #108451
Merged
DaveCTurner
merged 1 commit into
elastic:main
from
DaveCTurner:2024/05/09/searchable-snapshots-must-not-delete
May 9, 2024
Merged
Clarify docs on deleting searchable snapshots #108451
DaveCTurner
merged 1 commit into
elastic:main
from
DaveCTurner:2024/05/09/searchable-snapshots-must-not-delete
May 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The word `cannot` implies Elasticsearch prevents you from doing these things, but it doesn't have this protection today (see elastic#73947). This commit clarifies this by saying `must not` instead. Closes elastic#108450
DaveCTurner
added
>docs
General docs changes
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
v8.14.1
v8.15.0
v8.13.5
labels
May 9, 2024
Documentation preview: |
elasticsearchmachine
added
Team:Distributed
Meta label for distributed team
Team:Docs
Meta label for docs team
labels
May 9, 2024
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/es-distributed (Team:Distributed) |
kingherc
approved these changes
May 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DaveCTurner
added
the
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
label
May 9, 2024
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 9, 2024
The word `cannot` implies Elasticsearch prevents you from doing these things, but it doesn't have this protection today (see elastic#73947). This commit clarifies this by saying `must not` instead. Closes elastic#108450
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
May 9, 2024
The word `cannot` implies Elasticsearch prevents you from doing these things, but it doesn't have this protection today (see elastic#73947). This commit clarifies this by saying `must not` instead. Closes elastic#108450
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 9, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
May 9, 2024
kunisen
added a commit
that referenced
this pull request
May 17, 2024
Update searchable snapshot to clarify it's not a backup of index data and deleting it will result in permanent data loss. It's a follow up of #108451
DaveCTurner
added a commit
that referenced
this pull request
May 17, 2024
Relates #108451 Co-authored-by: David Turner <david.turner@elastic.co>
DaveCTurner
added a commit
that referenced
this pull request
May 17, 2024
Relates #108451 Co-authored-by: David Turner <david.turner@elastic.co>
DaveCTurner
added a commit
that referenced
this pull request
May 17, 2024
Relates #108451 Co-authored-by: David Turner <david.turner@elastic.co>
parkertimmins
pushed a commit
to parkertimmins/elasticsearch
that referenced
this pull request
May 17, 2024
Relates elastic#108451 Co-authored-by: David Turner <david.turner@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
:Distributed/Snapshot/Restore
Anything directly related to the `_snapshot/*` APIs
>docs
General docs changes
Team:Distributed
Meta label for distributed team
Team:Docs
Meta label for docs team
v8.13.5
v8.14.1
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The word
cannot
implies Elasticsearch prevents you from doing thesethings, but it doesn't have this protection today (see #73947). This
commit clarifies this by saying
must not
instead.Closes #108450