[ML] Fix for missed renaming in upgrade tests #108389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxhniebergall
added
the
auto-merge
|
Pinging @elastic/ml-core (Team:ML) |
maxhniebergall
changed the title
| @@ -71,7 +71,7 @@ public void testCohereEmbeddings() throws IOException { | |||
| cohereEmbeddingsServer.enqueue(new MockResponse().setResponseCode(200).setBody(embeddingResponseFloat())); | |||
| put(oldClusterIdFloat, embeddingConfigFloat(getUrl(cohereEmbeddingsServer)), TaskType.TEXT_EMBEDDING); | |||
|
|
|||
| var configs = (List<Map<String, Object>>) get(TaskType.TEXT_EMBEDDING, oldClusterIdInt8).get("models"); | |||
| var configs = (List<Map<String, Object>>) get(TaskType.TEXT_EMBEDDING, oldClusterIdInt8).get("endpoints"); | |||
There was a problem hiding this comment.
Are these changes trying to address the fact that these tests are muted? Or is it to bring the naming in alignment?
There was a problem hiding this comment.
This change won't fix these tests, but this change is required for the tests to be fixed/unmuted. I just noticed that these tests were broken when I copied them into my new mixed cluster tests.
jonathan-buttner
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some muted tests were missed in a recent PR, this change updates the ones in the muted upgrade tests