Drop shards close timeout when stopping node. #107978
Merged
+9
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.15.0
needs:triage
DaveCTurner
reviewed
Apr 27, 2024
There was a problem hiding this comment.
Thanks @howardhuanghua , just a couple of tiny points to address
| if (latch.await(shardsClosedTimeout.seconds(), TimeUnit.SECONDS) == false) { | ||
| logger.warn("Not all shards are closed yet, waited {}sec - stopping service", shardsClosedTimeout.seconds()); | ||
| } | ||
| // infinite wait |
There was a problem hiding this comment.
nit: no need for this comment here IMO, it's obviously a wait without a timeout now :)
server/src/main/java/org/elasticsearch/indices/IndicesService.java
Outdated
Show resolved
Hide resolved
DaveCTurner
added
:Distributed/Engine
|
Pinging @elastic/es-distributed (Team:Distributed) |
…java Co-authored-by: David Turner <david.turner@elastic.co>
DaveCTurner
added
the
auto-merge
|
@elasticmachine test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing #107938 to drop shards close timeout.