Encapsulate IndexShard/IndexService closing in tests #107974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closing an `IndexShard` or an `IndexService` requires some parameters that are not really important in tests. This commit encapsulates these calls into utility methods to populate those parameters with sensible values. Moreover it reduces some unnecessary noise in a follow-up PR which will make this closing process a little more complicated in production code without affecting all these tests. Relates elastic#107952
DaveCTurner
added
:Distributed/Engine
|
Pinging @elastic/es-distributed (Team:Distributed) |
|
Extracted from #107952 to reduce noise in that PR for easier reviewing. |
idegtiarenko
approved these changes
Apr 29, 2024
ywangd
reviewed
Apr 30, 2024
| @@ -363,7 +363,7 @@ public void testTranslogRecoveryWorksWithIMC() throws IOException { | |||
| for (int i = 0; i < 100; i++) { | |||
| indexDoc(shard, Integer.toString(i), "{\"foo\" : \"bar\"}", XContentType.JSON, null); | |||
| } | |||
| shard.close("simon says", false); | |||
There was a problem hiding this comment.
Bah I wish we could have preserved this great reason! :)
There was a problem hiding this comment.
it's still there in org.elasticsearch.indices.IndicesLifecycleListenerSingleNodeTests :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closing an
IndexShardor anIndexServicerequires some parametersthat are not really important in tests. This commit encapsulates these
calls into utility methods to populate those parameters with sensible
values. Moreover it reduces some unnecessary noise in a follow-up PR
which will make this closing process a little more complicated in
production code without affecting all these tests.
Relates #107952