New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Transform] Disable PIT for remote clusters #107969
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIT searches are still causing large data transfer rates when searching remote clusters. This is not a pure revert. The test code has been updated to match the latest on main. This reverts commit 9b584aa.
prwhelan
added
:ml/Transform
Transform
Team:ML
Meta label for the ML team
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
v8.14.1
v8.15.0
labels
Apr 26, 2024
Pinging @elastic/ml-core (Team:ML) |
Hi @prwhelan, I've created a changelog YAML for you. |
przemekwitek
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
prwhelan
added a commit
to prwhelan/elasticsearch
that referenced
this pull request
Apr 29, 2024
PIT searches are still causing large data transfer rates when searching remote clusters. This is not a pure revert. The test code has been updated to match the latest on main. This reverts commit 9b584aa.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Apr 29, 2024
* [Transform] Disable PIT for remote clusters (#107969) PIT searches are still causing large data transfer rates when searching remote clusters. This is not a pure revert. The test code has been updated to match the latest on main. This reverts commit 9b584aa. * [Transform] Remove remote cluster from local test This test can fail when we randomly add remote clusters. We would need to fix our assertion logic, but `testDisablePitWhenThereIsRemoteIndexInSource` already covers the test case when there is a remote cluster and pit disabled.
prwhelan
added a commit
that referenced
this pull request
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport-and-merge
Automatically create backport pull requests and merge when ready
>bug
:ml/Transform
Transform
Team:ML
Meta label for the ML team
v8.14.1
v8.15.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PIT searches are still causing large data transfer rates when searching remote clusters.
This is not a pure revert. The test code has been updated to match the latest on main.
This reverts commit 9b584aa.