Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Disable PIT for remote clusters #107969

Merged
merged 2 commits into from Apr 29, 2024
Merged

Conversation

prwhelan
Copy link
Member

PIT searches are still causing large data transfer rates when searching remote clusters.

This is not a pure revert. The test code has been updated to match the latest on main.

This reverts commit 9b584aa.

PIT searches are still causing large data transfer rates when searching
remote clusters.

This is not a pure revert.  The test code has been updated to match the
latest on main.

This reverts commit 9b584aa.
@prwhelan prwhelan added :ml/Transform Transform Team:ML Meta label for the ML team auto-backport-and-merge Automatically create backport pull requests and merge when ready v8.14.1 v8.15.0 labels Apr 26, 2024
@prwhelan prwhelan marked this pull request as ready for review April 26, 2024 21:54
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@prwhelan prwhelan added the >bug label Apr 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Hi @prwhelan, I've created a changelog YAML for you.

Copy link
Contributor

@przemekwitek przemekwitek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@prwhelan prwhelan merged commit 41d2df3 into elastic:main Apr 29, 2024
14 checks passed
prwhelan added a commit to prwhelan/elasticsearch that referenced this pull request Apr 29, 2024
PIT searches are still causing large data transfer rates when searching
remote clusters.

This is not a pure revert.  The test code has been updated to match the
latest on main.

This reverts commit 9b584aa.
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.14

elasticsearchmachine pushed a commit that referenced this pull request Apr 29, 2024
* [Transform] Disable PIT for remote clusters (#107969)

PIT searches are still causing large data transfer rates when searching
remote clusters.

This is not a pure revert.  The test code has been updated to match the
latest on main.

This reverts commit 9b584aa.

* [Transform] Remove remote cluster from local test

This test can fail when we randomly add remote clusters.  We would need
to fix our assertion logic, but
`testDisablePitWhenThereIsRemoteIndexInSource` already covers the test
case when there is a remote cluster and pit disabled.
prwhelan added a commit that referenced this pull request May 6, 2024
Relates #80187
Relates #107969

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready >bug :ml/Transform Transform Team:ML Meta label for the ML team v8.14.1 v8.15.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants