ESQL: Handle ADD near the end of time #107968
Conversation
This updates our tests to handle the case where you are adding a `TemporalAmount` to a date that is new `Long.MAX_VALUE`. It also adds a test case that generates dates new that time just so we catch errors out that way faster. Closes elastic#107817
nik9000
added
>test
|
Documentation preview: |
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
| @@ -3,7 +3,7 @@ | |||
| *Examples* | |||
|
|
|||
| `BUCKET` can work in two modes: one in which the size of the bucket is computed | |||
| based on a buckets count recommendation (four parameters) and a range, and | |||
| based on a buckets count recommendation (four parameters) and a range and | |||
There was a problem hiding this comment.
This just needed to be regenerated. It's not part of my change.
There was a problem hiding this comment.
Oops, looks like some changes were made in this asciidoc directly, rather than in org/elasticsearch/xpack/esql/expression/function/grouping/Bucket.java.
@bpintea, could you please double check this? This shouldn't block this PR, but maybe we need a tiny follow-up PR to fix this.
There was a problem hiding this comment.
Thanks Alex, raised #108005.
nik9000
changed the title
| @@ -3,7 +3,7 @@ | |||
| *Examples* | |||
|
|
|||
| `BUCKET` can work in two modes: one in which the size of the bucket is computed | |||
| based on a buckets count recommendation (four parameters) and a range, and | |||
| based on a buckets count recommendation (four parameters) and a range and | |||
There was a problem hiding this comment.
Oops, looks like some changes were made in this asciidoc directly, rather than in org/elasticsearch/xpack/esql/expression/function/grouping/Bucket.java.
@bpintea, could you please double check this? This shouldn't block this PR, but maybe we need a tiny follow-up PR to fix this.
|
I'll drop the asciidoc from this one. |
nik9000
added
the
auto-merge
#108005 is merged, so the asciidoc is no longer regenerated by tests now. |
This updates our tests to handle the case where you are adding a
TemporalAmountto a date that is newLong.MAX_VALUE. It also adds a test case that generates dates new that time just so we catch errors out that way faster.Closes #107817