Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding docs about scaled_float saturation with long values #107966

Merged
merged 2 commits into from Apr 30, 2024
Merged

Adding docs about scaled_float saturation with long values #107966

merged 2 commits into from Apr 30, 2024

Conversation

benwtrent
Copy link
Member

@benwtrent benwtrent commented Apr 26, 2024 •
edited

closes: #105361

@github-actions GitHub Actions
Copy link

Documentation preview:

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:Search Meta label for search team labels Apr 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

shainaraskas
shainaraskas approved these changes Apr 29, 2024
View reviewed changes
docs/reference/mapping/types/numeric.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/numeric.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/numeric.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/numeric.asciidoc Outdated Show resolved Hide resolved
docs/reference/mapping/types/numeric.asciidoc Outdated
However, the value actually stored is +9223372036854775807+, the maximum value for a `long`.

This can lead to unexpected results with <<query-dsl-range-query,range queries>>
when the scaling factor is large or the value is close to the maximum value of a `long`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unclear whether value here is the scaled float or the original value before scaling. assume the former, so maybe we should say resulting scaled value?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I adjusted, what do you think? I mean the provided value, not the stored one. If the stored one is "near" the maximum, who cares, its all about when it exceeds the maximum.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes more sense - thanks!

@benwtrent @shainaraskas
Apply suggestions from code review
5433a0f 
Co-authored-by: shainaraskas <58563081+shainaraskas@users.noreply.github.com>
@benwtrent benwtrent merged commit 67748cf into elastic:main Apr 30, 2024
5 checks passed
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (elastic#1…
aaef097 
…07966)
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
❌ 8.0 Commit could not be cherrypicked due to conflicts
❌ 8.1 Commit could not be cherrypicked due to conflicts
❌ 8.2 Commit could not be cherrypicked due to conflicts
❌ 8.3 Commit could not be cherrypicked due to conflicts
✅ 8.4
✅ 8.5
✅ 8.6
✅ 8.7
✅ 8.8
✅ 8.9
✅ 8.10
✅ 8.11
✅ 8.12
✅ 8.14
✅ 8.13
❌ 7.17 Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 107966

@benwtrent benwtrent mentioned this pull request Apr 30, 2024
Merged
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (elastic#1…
3aac56d 
…07966)

(cherry picked from commit 67748cf)
@benwtrent benwtrent mentioned this pull request Apr 30, 2024
Merged
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (elastic#1…
1b1e55a 
…07966)

(cherry picked from commit 67748cf)
@benwtrent benwtrent mentioned this pull request Apr 30, 2024
Merged
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (elastic#1…
d961c02 
…07966)

(cherry picked from commit 67748cf)
@benwtrent benwtrent mentioned this pull request Apr 30, 2024
Merged
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (elastic#1…
7d3b130 
…07966)

(cherry picked from commit 67748cf)
@benwtrent benwtrent mentioned this pull request Apr 30, 2024
Merged
@benwtrent
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
✅ 8.3
✅ 8.2
✅ 8.1
✅ 8.0
✅ 7.17

Questions ?

Please refer to the Backport tool documentation

benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (elastic#1…
3143b4e 
…07966)

(cherry picked from commit 67748cf)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
11db216 
…108074)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
ba99492 
…108071)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
99ffed1 
…108075)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
4d5fc4a 
…108073)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
aef145d 
…108076)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
834f339 
…108072)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
b8b9284 
…108077)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
8e2b441 
…108078)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
772229e 
…108080)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
14370f6 
…108081)
elasticsearchmachine pushed a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
9b9c9ca 
…108079)
benwtrent added a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
6233481 
…108086)

(cherry picked from commit 67748cf)
benwtrent added a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
b1da2e3 
…108087)

(cherry picked from commit 67748cf)
benwtrent added a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
f7da4fb 
…108085)

(cherry picked from commit 67748cf)
benwtrent added a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
d822312 
…108084)

(cherry picked from commit 67748cf)
benwtrent added a commit that referenced this pull request Apr 30, 2024
@benwtrent
Adding docs about scaled_float saturation with long values (#107966) (#…
8b55b21 
…108083)

(cherry picked from commit 67748cf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shainaraskas shainaraskas shainaraskas approved these changes

Assignees
No one assigned
Labels
auto-backport-and-merge Automatically create backport pull requests and merge when ready backport pending >docs General docs changes :Search/Mapping Index mappings, including merging and defining field types Team:Docs Meta label for docs team Team:Search Meta label for search team v7.17.22 v8.0.2 v8.1.4 v8.2.4 v8.3.4 v8.4.4 v8.5.4 v8.6.3 v8.7.2 v8.8.3 v8.9.3 v8.10.5 v8.11.5 v8.12.3 v8.13.4 v8.14.1 v8.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scale_float does not honor limits for long values
3 participants
@benwtrent @elasticsearchmachine @shainaraskas