Make MappedActionFilter its own interface #107960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MappedActionFilter is an ActionFilter, but it has no defined order. Yet the order method is still required to be implemented. This commit makes MappedActionFilter its own interface that does not contain order. The apply method is the exact same as ActionFilter, so it still works just as before, but there will be less confusion over whether order is required or applicable.
elasticsearchmachine
added
v8.15.0
Team:Core/Infra
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
nielsbauman
added a commit
that referenced
this pull request
May 2, 2024
This reverts commit 4dcf371.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
May 2, 2024
This commit reapplies the change from elastic#107960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MappedActionFilter is an ActionFilter, but it has no defined order. Yet the order method is still required to be implemented. This commit makes MappedActionFilter its own interface that does not contain order. The apply method is the exact same as ActionFilter, so it still works just as before, but there will be less confusion over whether order is required or applicable.