Fix random sampler consistency test #107957
Open
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benwtrent
added
>test
|
Pinging @elastic/es-search (Team:Search) |
|
@elasticmachine update branch |
| public void testRandomSamplerConsistentSeed() { | ||
| double[] sampleMonotonicValue = new double[1]; | ||
| double[] sampleNumericValue = new double[1]; | ||
| long[] sampledDocCount = new long[1]; | ||
| // Force merge to ensure segment consistency as any segment merging can change which particular documents | ||
| // are sampled | ||
| assertNoFailures(indicesAdmin().prepareForceMerge("idx").setMaxNumSegments(1).get()); |
There was a problem hiding this comment.
I see that idx index is setup and indexed once for all tests in this module. Is this correct? If so, I have 2 questions:
- Is it being force-merged to 1 segment having any influence on other tests?
- Does it make sense to move force-merge to
setupSuiteScopeCluster()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Random sampler consistency requires a restricted number of segments, to ensure we always hit the same number of segments and that no merging is occurring, this merges the segment count to 1 for this particular test.
In practice, this isn't needed as the approximate nature of the aggregation already means you could get different statistics per call, but they are within an error bound set by the users configured sampling probability.
closes: #105839