Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop IndicesService#shardsClosedTimeout #107938

Open
DaveCTurner opened this issue Apr 26, 2024 · 1 comment
Open

Drop IndicesService#shardsClosedTimeout #107938

DaveCTurner opened this issue Apr 26, 2024 · 1 comment
Labels
:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed Meta label for distributed team >tech debt

Comments

@DaveCTurner
Copy link
Contributor

We wait for up to IndicesService#shardsClosedTimeout for shards to fully close when shutting down a node, which defaults to 1 day (and AFAICT nobody changes this). Imposing this timeout seems fairly pointless, it's likely that some other mechanism will forcefully terminate the whole process before this timeout expires, but if it doesn't then maybe we should keep on waiting. Let's remove this timeout and make it an infinite wait.
@DaveCTurner DaveCTurner added :Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. >tech debt labels Apr 26, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team label Apr 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@howardhuanghua howardhuanghua mentioned this issue Apr 27, 2024
Merged
elasticsearchmachine pushed a commit that referenced this issue May 3, 2024
@howardhuanghua
Drop shards close timeout when stopping node. (#107978)
8c8063b 
Closing #107938 to drop
shards close timeout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Distributed/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed Meta label for distributed team >tech debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DaveCTurner @elasticsearchmachine