Skip to content

Commit

Permalink
Use RUNTIME_JAVA_HOME for test clusters (#73003)
Browse files Browse the repository at this point in the history
  • Loading branch information
mark-vieira committed May 26, 2021
1 parent 4c5f2e4 commit 14f3273
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Expand Up @@ -700,8 +700,8 @@ class ClusterFormationTasks {
esJavaOpts.add('-agentlib:jdwp=transport=dt_socket,server=y,suspend=y,address=8000')
}
node.env['ES_JAVA_OPTS'] = esJavaOpts.join(" ")
node.env['JAVA_HOME'] = node.getJavaHome()

//
project.logger.info("Starting node in ${node.clusterName} distribution: ${node.config.distribution}")
}
return start
Expand Down
Expand Up @@ -30,9 +30,9 @@
* gets reflected in the dataset structure.
* The doc tests while redundant, try to be expressive first and foremost and sometimes
* the dataset isn't exactly convenient.
*
*
* Also looking around for the tests across the test files isn't trivial.
*
*
* That's not to say the two cannot be merged however that felt like too much of an effort
* at this stage and, to not keep things stalling, started with this approach.
*/
Expand Down Expand Up @@ -69,7 +69,7 @@ protected void assertResults(ResultSet expected, ResultSet elastic) throws SQLEx
// uncomment this to printout the result set and create new CSV tests
//
//JdbcTestUtils.logLikeCLI(elastic, log);
JdbcAssert.assertResultSets(expected, elastic, log, true, false);
JdbcAssert.assertResultSets(expected, elastic, log, true, true);
}

@Override
Expand All @@ -87,4 +87,4 @@ protected final void doTest() throws Throwable {
assertResults(expected, elasticResults);
}
}
}
}

0 comments on commit 14f3273

Please sign in to comment.