Support psr/log:^3
#1187
Closed
Support psr/log:^3
#1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See php-fig/log@2.0.0...3.0.0 `psr/log:3.0.0` adds return types to all signatures: we don't implement `psr/log`, but only consume it, so we should be fine here.
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
💚 CLA has been signed |
|
It's signed, but the CLA process verification craps out because of blacklisted domains that do network tracking, and are (rightfully) blocked by my own network rules. Feel free to look it up. |
|
Duplicate of #1184 but I don't mind which one is merged :D |
Closed
|
Closing, as duplicate of #1184. Please check for existing PRs before submitting a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See php-fig/log@2.0.0...3.0.0
psr/log:3.0.0adds return types to all signatures: we don't implementpsr/log, but only consume it, so we should be fine here.