Add improvements to response _DESERIALIZER #772
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change deserializer to use emptyObject(T) for responses that return empty objects
|
Looks fine to me at a glance, but unfortunately not in a position to test ATM and don't have permissions to make a useful review. |
|
Appreciate for the feedback! I hope to get further comments from this open source administrators. |
|
Closing this because it was fixed in the code generator |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a number of enhancements to several response classes.
co.elastic.clients.elasticsearch.security:
DisableUserResponseEnableUserResponseChangePasswordResponseco.elastic.clients.elasticsearch.indices:
SimulateIndexTemplateResponseFor the response that returns an empty object, or has a possibility according to the server-side code, _DESERIALIZER should use
emptyObject(T)from the JsonpDeserializer.For more detailed specifications regarding this PR, please refer to #718 (comment).