-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle string ports in docker compose v2 config yaml #748
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the moment, when we should use Compose V2 in general for CI testing?
I think we are close, the main blocker I have found so far with v2 has been not being able to use Something we might also investigate is to use the Go API 🙂, so we don't depend on the installed binary. |
/test |
Actually this may be a bug in docker compose. This is the documented format:
This is what I am finding:
|
Open issue in docker compose project: docker/compose#9306 |
Using docker-compose v2.3.x (go implementation),
elastic-package shellinit
fails with:This seems to happen because some ports are represented as strings in the
docker-compose config
output.Support both versions by allowing ports to be integers or numbers.