Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deps): update dependency d3-interpolate to v3.0.1 #1670

Merged
merged 2 commits into from Jun 15, 2022
Merged

fix(deps): update dependency d3-interpolate to v3.0.1 #1670

merged 2 commits into from Jun 15, 2022

Conversation

watson
Copy link
Member

@watson watson commented May 11, 2022 •
edited

I'm performing this upgrade to get a newer version of d3-color which is a direct dependency of d3-interpolate.

The breaking changes introduced in this newer version of d3-interpolate are:

  • Change d3.interpolateTransformCss to use DOMMatrix and require absolute units. Use DOMMatrix to parse CSS transforms. d3/d3-interpolate#83 - This shouldn't be an issue since @elastic/charts doesn't use d3.interpolateTransformCss.
  • Adopts ES2015 language features such as for-of and drops support for older browsers, including IE - I'm not sure if this is an issue for @elastic/charts?
  • Requires Node.js 12 or higher - I'm not sure if this is an issue for @elastic/charts?

@watson watson marked this pull request as ready for review May 11, 2022 08:39
@markov00
Copy link
Member

Adopts ES2015 language features such as for-of and drops support for older browsers, including IE - I'm not sure if this is an issue for @elastic/charts?

@watson is that an issue for Kibana?

@watson
Copy link
Member Author

watson commented May 11, 2022

No, ES2015 isn't a problem for Kibana.

The only potential issue would be that Kibana still cannot process ES module style packages. However, this is only if they are direct dependencies. We already have sevel sub-dependencies that are of the ES module variant.

@markov00 markov00 self-requested a review June 15, 2022 13:22
@markov00 markov00 merged commit 893e895 into elastic:master Jun 15, 2022
nickofthyme pushed a commit that referenced this pull request Jun 16, 2022
@semantic-release-bot
chore(release): 46.10.2 [skip ci]
1c7996d 
## [46.10.2](v46.10.1...v46.10.2) (2022-06-16)

### Bug Fixes

* **deps:** update dependency d3-interpolate to v3.0.1 ([#1670](#1670)) ([893e895](893e895))
* **heatmap:** don't render null values ([#1708](#1708)) ([1c140bf](1c140bf))
@watson watson deleted the bump-d3-interpolate branch July 11, 2022 07:47
@SiddharthMantri SiddharthMantri mentioned this pull request Nov 2, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markov00 markov00 markov00 approved these changes

@nickofthyme nickofthyme nickofthyme approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@watson @markov00 @nickofthyme