Skip ActivityData capture for NLog, since doing Layout capture #379
+88
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snakefoot
force-pushed
the
net6
branch
2 times, most recently
from
cf1fd62
to
084a6c3
Compare
snakefoot
force-pushed
the
net6
branch
2 times, most recently
from
439efad
to
f48620b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling writing on background-thread, then one should not capture the activity-traceid of the background-thread.
I guess Serilog has the same issue, since it relies on its enricher-capture (similar to NLog layout capture)
This is ofcourse a breaking change, since adding new property to existing interface
IEcsDocumentCreationOptions. Maybe change to use enum-flag-values?Alternative only perform automatic capture for Elastic.Extensions.Logging? (Skip helping NLog / Serilog / Log4net)