Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix goreleaser config. #627

Merged
merged 3 commits into from Oct 23, 2023
Merged

Fix goreleaser config. #627

merged 3 commits into from Oct 23, 2023

Conversation

gigerdo
Copy link
Member

@gigerdo gigerdo commented Oct 23, 2023

Updates to latest goreleaser, fixes all configs/parameters that are deprecated with this release.

The 'replacements' parameter was removed in goreleaser. The name now has to be built directly in the file-name template.

(See: goreleaser/goreleaser#3588 (comment))

Description

Related Issues

Motivation and Context

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (improves code quality but has no user-facing effect)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Readiness Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

@gigerdo
Fix goreleaser config.
374664e 
The 'replacements' parameter was removed in goreleaser. The name now has to be built directly in the file-name template.

(See: goreleaser/goreleaser#3588 (comment))
@gigerdo gigerdo marked this pull request as ready for review October 23, 2023 09:56
@gigerdo gigerdo requested a review from a team as a code owner October 23, 2023 09:56
dimuon
dimuon approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@dimuon dimuon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gigerdo gigerdo merged commit 74e63ed into elastic:master Oct 23, 2023
2 of 3 checks passed
@gigerdo gigerdo deleted the fix-goreleaser branch October 23, 2023 12:37
@claudia-correia claudia-correia mentioned this pull request Dec 20, 2023
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimuon dimuon dimuon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gigerdo @dimuon