Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release Notes + Highlights for 2.11.1 #7510

Merged
merged 6 commits into from
Jan 29, 2024
Merged

Release Notes + Highlights for 2.11.1 #7510

merged 6 commits into from
Jan 29, 2024

Conversation

naemono
Copy link
Contributor

@naemono naemono commented Jan 26, 2024

This adds release notes and highlights for the upcoming 2.11.1 release.
Also added known issues section in 2.11.0 highlights.

@naemono
Release notes + Highlights for 2.11.1
bec756c 
Also added known issues section in 2.11.0 highlights.

Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
@naemono
Reference release notes/highlights 2.11.1
1097335 
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
@naemono naemono added >docs Documentation exclude-from-release-notes Exclude this PR from appearing in the release notes labels Jan 26, 2024
@naemono
reword
90aff0b 
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
naemono
naemono commented Jan 26, 2024
View reviewed changes
docs/release-notes/highlights-2.11.0.asciidoc Outdated
[float]
[id="{p}-2110-known-issues"]
=== Known issues
- The `resourceStatuses` field of the status subresource of the Stack Configuration Policy was removed which could cause errors in the operator logs during an upgrade.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm unsure about this wording, and how we would prefer to word this. Comments appreciated.

@naemono naemono changed the title Release notes + Highlights for 2.11.1 Release Notes + Highlights for 2.11.1 Jan 26, 2024
@naemono
Copy link
Contributor Author

naemono commented Jan 26, 2024

CI is noting changes such as these are needed, but I can't seem to get this format to generate locally. Any ideas?

-                      description: CurrentVersion denotes the current version of filesettings
-                        applied to the Elasticsearch cluster This field does not apply
-                        to Kibana resources
+                      description: \|-
+                        CurrentVersion denotes the current version of filesettings applied to the Elasticsearch cluster
+                        This field does not apply to Kibana resources

barkbay
barkbay reviewed Jan 29, 2024
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe update the statement here:

[...] there should be no impact on users [...]

To mention what should be a the temporary disruption when installing 2.11.0 and 2.11.1 has been released to workaround that?

@barkbay
Copy link
Contributor

barkbay commented Jan 29, 2024

CI is noting changes such as these are needed, but I can't seem to get this format to generate locally. Any ideas?

Yes, this: kubernetes-sigs/controller-tools#870, which was introduced in the recently updated v0.14.0. It leads to the following files being updated on main if you run make generate:

On branch main
Your branch is up to date with 'origin/main'.

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        modified:   config/crds/v1/all-crds.yaml
        modified:   config/crds/v1/bases/stackconfigpolicy.k8s.elastic.co_stackconfigpolicies.yaml
        modified:   deploy/eck-operator/charts/eck-operator-crds/templates/all-crds.yaml

pebrc
pebrc reviewed Jan 29, 2024
View reviewed changes
Copy link
Collaborator

@pebrc pebrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • 1 on updating the breaking changes statement for 2.11.0 as well.

docs/release-notes/highlights-2.11.0.asciidoc Outdated Show resolved Hide resolved
@naemono
make generate with controller-tools@v0.14.0
bc0f87d 
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
@naemono
Update wording per review comments.
8e27de0 
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
@naemono naemono requested review from barkbay and pebrc January 29, 2024 14:15
barkbay
barkbay approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@barkbay barkbay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/release-notes/2.11.0.asciidoc Outdated Show resolved Hide resolved
@naemono
Update wording.
146f943 
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
@naemono
Copy link
Contributor Author

naemono commented Jan 29, 2024

@elasticmachine run elasticsearch-ci/doc

@naemono naemono merged commit c95a6ca into elastic:main Jan 29, 2024
6 checks passed
@naemono naemono deleted the release-notes-highlights-2.11.1 branch January 29, 2024 16:45
@naemono
Copy link
Contributor Author

naemono commented Jan 29, 2024

💚 All backports created successfully

Status Branch Result
✅ 2.11.1-wip

Questions ?

Please refer to the Backport tool documentation

@naemono naemono mentioned this pull request Jan 29, 2024
Merged
naemono added a commit to naemono/cloud-on-k8s that referenced this pull request Jan 29, 2024
@naemono
Release Notes + Highlights for 2.11.1 (elastic#7510)
12c436b 
* Release notes + Highlights for 2.11.1
* Also added known issues section in 2.11.0 highlights.
---------
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
(cherry picked from commit c95a6ca)
naemono added a commit that referenced this pull request Jan 29, 2024
@naemono
Release Notes + Highlights for 2.11.1 (#7510) (#7513)
ddde995 
* Release notes + Highlights for 2.11.1
* Also added known issues section in 2.11.0 highlights.
---------
Signed-off-by: Michael Montgomery <mmontg1@gmail.com>
(cherry picked from commit c95a6ca)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barkbay barkbay barkbay approved these changes

@thbkrkr thbkrkr Awaiting requested review from thbkrkr

@rhr323 rhr323 Awaiting requested review from rhr323

@kvalliyurnatt kvalliyurnatt Awaiting requested review from kvalliyurnatt

@pebrc pebrc Awaiting requested review from pebrc

Assignees
No one assigned
Labels
>docs Documentation exclude-from-release-notes Exclude this PR from appearing in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@naemono @barkbay @pebrc