Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Add stringer redaction to synthexec cmd #39535

Merged
merged 7 commits into from
May 16, 2024

Conversation

emilioalvap
Copy link
Collaborator

@emilioalvap emilioalvap commented May 13, 2024

Proposed commit message

Redact synthetics cmd output to prevent logging of user-defined parameters.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

N/A

How to test this PR locally

  1. Build heartbeat locally.
  2. Add a browser monitor with any playwrightOpts or params.
  3. Run and check logs show playwrightOpts or params as REDACTED

@emilioalvap emilioalvap added bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.12.0 labels May 13, 2024
@emilioalvap emilioalvap requested a review from a team as a code owner May 13, 2024 15:48
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 13, 2024
Copy link
Contributor

mergify bot commented May 13, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @emilioalvap? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilioalvap emilioalvap added the backport-v8.14.0 Automated backport with mergify label May 16, 2024
@emilioalvap emilioalvap merged commit 7306bd4 into elastic:main May 16, 2024
15 checks passed
mergify bot pushed a commit that referenced this pull request May 16, 2024
Redact synthetics cmd output to prevent logging of user-defined parameters.

---------

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
(cherry picked from commit 7306bd4)
vigneshshanmugam added a commit that referenced this pull request May 16, 2024
Redact synthetics cmd output to prevent logging of user-defined parameters.

---------

Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
(cherry picked from commit 7306bd4)

Co-authored-by: Emilio Alvarez Piñeiro <95703246+emilioalvap@users.noreply.github.com>
Co-authored-by: Vignesh Shanmugam <vignesh.shanmugam22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.14.0 Automated backport with mergify bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants