Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.14](backport #39510) Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines #39520

Merged
merged 2 commits into from May 15, 2024
Merged

[8.14](backport #39510) Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines #39520

merged 2 commits into from May 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 10, 2024

Proposed commit message

Explicitly set DOCKER_PULL , RACE_DETECTOR and TEST_COVERAGE variables for pipelines
The previous approach is unobvious and error-prone

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Relates https://github.com/elastic/ingest-dev/issues/3303

This is an automatic backport of pull request #39510 done by [Mergify](https://mergify.com).

@pazone @mergify
Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipel…
d4222be 
…ines (#39510)

* Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines

* Moved DOCKER_PULL var to winlogonbeat pipeline

* added xpack/heartbeat

(cherry picked from commit c773028)
@mergify mergify bot requested a review from a team as a code owner May 10, 2024 18:08
@mergify mergify bot added the backport label May 10, 2024
@mergify mergify bot assigned pazone May 10, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2024
@botelastic
Copy link

botelastic bot commented May 10, 2024

This pull request doesn't have a Team:<team> label.

@mergify Mergify
Copy link
Contributor Author

mergify bot commented May 13, 2024

This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏

dliappis
dliappis approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pazone pazone enabled auto-merge (squash) May 14, 2024 14:20
@mergify Mergify
Copy link
Contributor Author

mergify bot commented May 14, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.14/pr-39510 upstream/mergify/bp/8.14/pr-39510
git merge upstream/8.14
git push upstream mergify/bp/8.14/pr-39510

@pazone pazone merged commit 1eedfac into 8.14 May 15, 2024
104 of 105 checks passed
@pazone pazone deleted the mergify/bp/8.14/pr-39510 branch May 15, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@pazone pazone

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dliappis @pazone