Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14](backport #39404) Add error check to groupToEvents so we don't blindly add error values #39504

Merged
merged 2 commits into from May 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 10, 2024

Proposed commit message

fixes #38140

This adds an error check to the eventMap in groupToEvents() so we don't report an error where there isn't one.

I almost never touch any of the windows code, so feel free to ignore this until CI is green.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

This is an automatic backport of pull request #39404 done by [Mergify](https://mergify.com).

…#39404)

* add error check to perfmon groupToEvents

* linter...

* tests

* add changelog

* fix changelog

* make linter happy

(cherry picked from commit 760208b)
@mergify mergify bot requested a review from a team as a code owner May 10, 2024 06:34
@mergify mergify bot added the backport label May 10, 2024
@mergify mergify bot requested review from faec and leehinman and removed request for a team May 10, 2024 06:34
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2024
@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label May 10, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2024
Copy link
Contributor Author

mergify bot commented May 13, 2024

This pull request has not been merged yet. Could you please review and merge it @fearful-symmetry? 🙏

Copy link
Contributor Author

mergify bot commented May 14, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.14/pr-39404 upstream/mergify/bp/8.14/pr-39404
git merge upstream/8.14
git push upstream mergify/bp/8.14/pr-39404

@ycombinator ycombinator enabled auto-merge (squash) May 15, 2024 21:39
@ycombinator ycombinator merged commit e090084 into 8.14 May 15, 2024
19 of 20 checks passed
@ycombinator ycombinator deleted the mergify/bp/8.14/pr-39404 branch May 15, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants