Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix errors in pymongo tests introduced in #1639 #1648

Merged
merged 2 commits into from Oct 3, 2022
Merged

fix errors in pymongo tests introduced in #1639 #1648

merged 2 commits into from Oct 3, 2022

Conversation

beniwohli
Copy link
Contributor

What does this pull request do?

@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Sep 27, 2022
@apmmachine
Copy link
Collaborator

apmmachine commented Sep 27, 2022 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-29T09:27:51.320+0000

  • Duration: 31 min 32 sec

Test stats 🧪

Test Results
Failed 0
Passed 4991
Skipped 3337
Total 8328

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /test linters : Run the Python linters only.

  • /test full : Run the full matrix of tests.

  • /test benchmark : Run the APM Agent Python benchmarks tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Collaborator

apmmachine commented Sep 27, 2022 •
edited

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 100.0% (66/66) 💚
Files 100.0% (225/225) 💚
Classes 100.0% (225/225) 💚
Lines 89.849% (17579/19565) 👍
Conditionals 77.15% (3221/4175) 👍

@beniwohli
Copy link
Contributor Author

/test full

@beniwohli
Copy link
Contributor Author

/test full

@beniwohli
Copy link
Contributor Author

the remaining test failures are with the starlette instrumentation, probably due to encode/starlette#1376

@beniwohli
Copy link
Contributor Author

/test

@basepi basepi merged commit 5447d49 into elastic:main Oct 3, 2022
APM-Agents (OLD) automation moved this from In Progress to Done Oct 3, 2022
v1v added a commit to v1v/apm-agent-python that referenced this pull request Oct 11, 2022
@v1v
Merge remote-tracking branch 'upstream/main' into feature/unit-test-w…
a5d640e 
…ith-k8s-skaffold

* upstream/main:
  bump python versions and use docker slim versions (elastic#1661)
  use github actions for pre-commit checks (elastic#1658)
  Use typing.TypeVar on decorators' type hints (elastic#1655)
  Use minimum of 5 seconds for interval between central config calls (elastic#1652)
  fix errors in pymongo tests introduced in elastic#1639 (elastic#1648)
  only use content-type and content-encoding headers for POSTing events (elastic#1651)
  fix starlette 0.21 tests (elastic#1653)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basepi basepi basepi approved these changes

Assignees
No one assigned
Labels
agent-python
Projects
APM-Agents (OLD)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@beniwohli @apmmachine @basepi