fix: correct dev-deps required for the recent eslint@8 upgrade #3449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The upgrade to eslint@8 in #3409 subtly broken peer-dependencies. `npm ls` unhelpfully does not complain, but `npm ls -a` shows some errors, and `./dev-utils/make-distribution.sh` was broken. The upgrade bumped "eslint-config-standard" from ^14.1.1 to ^16. However, v16 has: "peerDependencies": { "eslint": "^7.12.1", "eslint-plugin-import": "^2.22.1", "eslint-plugin-node": "^11.1.0", "eslint-plugin-promise": "^4.2.1 || ^5.0.0" }, so is incompatible with eslint@8. We need eslint-config-standard@17, which has: "peerDependencies": { "eslint": "^8.0.1", "eslint-plugin-import": "^2.25.2", "eslint-plugin-n": "^15.0.0 || ^16.0.0 ", "eslint-plugin-promise": "^6.0.0" }, Note that also requires a change from eslint-plugin-node (unmaintained) to the replacement "eslint-plugin-n".
github-actions
bot
added
the
agent-nodejs
|
The errors that The error in make-distribution.sh (which would have showed up when attempting to do a release): |
trentm
changed the title
trentm
changed the title
|
Lovely. These dev-dep updates change the eslint rules in play, so now lint fails: lint failures |
|
eslint-config-standard@17 changes: https://github.com/standard/standard/blob/master/CHANGELOG.md#1700---2022-04-20
|
eslint-config-standard@17 added https://eslint.org/docs/latest/rules/object-shorthand as a warning. It'll become "error" in a subsequent major.
…e are on eslint@8
david-luna
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The upgrade to eslint@8 in #3409 subtly broken peer-dependencies.
npm lsunhelpfully does not complain, butnpm ls -ashows someerrors, and
./dev-utils/make-distribution.shwas broken.The upgrade bumped "eslint-config-standard" from ^14.1.1 to ^16.
However, v16 has:
so is incompatible with eslint@8. We need eslint-config-standard@17,
which has:
Note that also requires a change from eslint-plugin-node (unmaintained)
to the replacement "eslint-plugin-n".