JDK 15+16 test fixes #2158

SylvainJuge · 2021-09-28T10:27:52Z

jedis test fails due to known jdk 15 bug
fix test SSL context init work-around
tried to investigate a bit why log shading fails on Java 15 without success, thus disabling those tests on this JDK.

apmmachine · 2021-09-28T10:29:04Z

💔 Tests Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2021-11-08T07:39:47.117+0000
Duration: 27 min 39 sec
Commit: cd47c96

Test stats 🧪

Test	Results
Failed	1
Passed	1376
Skipped	3
Total	1380

Test errors

Expand to view the tests failures

`Tests / Unit Tests / verifyThatTransactionWithSpanCreated – co.elastic.apm.agent.rabbitmq.AsyncRabbitListenerTest`

no error details

Expand to view the stacktrace

 java.util.concurrent.TimeoutException
	at java.base/java.util.concurrent.FutureTask.get(FutureTask.java:204)
	at org.springframework.util.concurrent.SettableListenableFuture.get(SettableListenableFuture.java:134)
	at co.elastic.apm.agent.rabbitmq.AbstractAsyncRabbitMqTest.verifyThatTransactionWithSpanCreated(AbstractAsyncRabbitMqTest.java:50)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
	at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
	at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
	at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
	at org.springframework.test.context.junit4.statements.RunBeforeTestExecutionCallbacks.evaluate(RunBeforeTestExecutionCallbacks.java:74)
	at org.springframework.test.context.junit4.statements.RunAfterTestExecutionCallbacks.evaluate(RunAfterTestExecutionCallbacks.java:84)
	at org.springframework.test.context.junit4.statements.RunBeforeTestMethodCallbacks.evaluate(RunBeforeTestMethodCallbacks.java:75)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.springframework.test.context.junit4.statements.RunAfterTestMethodCallbacks.evaluate(RunAfterTestMethodCallbacks.java:86)
	at org.springframework.test.context.junit4.statements.SpringRepeat.evaluate(SpringRepeat.java:84)
	at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:251)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.runChild(SpringJUnit4ClassRunner.java:97)
	at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
	at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
	at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
	at org.springframework.test.context.junit4.statements.RunBeforeTestClassCallbacks.evaluate(RunBeforeTestClassCallbacks.java:61)
	at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
	at org.springframework.test.context.junit4.statements.RunAfterTestClassCallbacks.evaluate(RunAfterTestClassCallbacks.java:70)
	at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
	at org.springframework.test.context.junit4.SpringJUnit4ClassRunner.run(SpringJUnit4ClassRunner.java:190)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at org.junit.vintage.engine.execution.RunnerExecutor.execute(RunnerExecutor.java:42)
	at org.junit.vintage.engine.VintageTestEngine.executeAllChildren(VintageTestEngine.java:80)
	at org.junit.vintage.engine.VintageTestEngine.execute(VintageTestEngine.java:72)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:220)
	at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$6(DefaultLauncher.java:188)
	at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:202)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:181)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invokeAllTests(JUnitPlatformProvider.java:150)
	at org.apache.maven.surefire.junitplatform.JUnitPlatformProvider.invoke(JUnitPlatformProvider.java:124)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:384)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:345)
	at org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:126)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:418)

Steps errors

Expand to view the steps failures

`Shell Script`

Took 11 min 25 sec . View more details here
Description: #!/bin/bash set -euxo pipefail ./mvnw test

🐛 Flaky test report

❕ There are test failures but not known flaky tests.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
run benchmark tests : Run the benchmark test.
run compatibility tests : Run the JDK Compatibility test.
run integration tests : Run the APM-ITs.

…ew-java15-16-tests

SylvainJuge · 2021-10-11T09:39:22Z

run compatibility tests

eyalkoren · 2021-10-11T12:33:31Z

...n-plugin/src/test/java/co/elastic/apm/agent/urlconnection/SSLContextInstrumentationTest.java

+            checkDefaultFactory(true);
+            createConnection();


No need - in the original test, we would test the field itself starts as null and that a creation of HTTPS connection initializes it.

eyalkoren · 2021-10-11T13:29:05Z

run compatibility tests

SylvainJuge · 2021-10-12T09:13:26Z

Marked as blocked by #2184
Those JDK 15 and 16 test failures are too noisy, thus fixing JDK 17 first has higher priority.

SylvainJuge · 2021-12-08T14:49:16Z

Closing this for now as JDK 16 support is currently OK and JDK 15 is documented as having issues in #2327

SylvainJuge added 2 commits September 28, 2021 12:26

jedis test fails due to known jdk 15 bug

d21f7cc

fix test SSL context init work-around

d90f95a

github-actions bot added the agent-java label Sep 28, 2021

elastic-apm-tech added this to In Progress in APM-Agents (OLD) Sep 28, 2021

SylvainJuge added 2 commits September 28, 2021 16:06

better msg for lack of shaded log file

e172dbf

give up on jdk15 for log shading for now

eb86a9b

AlexanderWert added the chore label Oct 11, 2021

Merge branch 'master' of github.com:elastic/apm-agent-java into fix-f…

cd47c96

…ew-java15-16-tests

SylvainJuge marked this pull request as ready for review October 11, 2021 09:39

eyalkoren approved these changes Oct 11, 2021

View reviewed changes

SylvainJuge added the blocked label Oct 12, 2021

SylvainJuge moved this from In Progress to Blocked in APM-Agents (OLD) Oct 12, 2021

SylvainJuge mentioned this pull request Dec 8, 2021

JDK 17 Official support #2327

Merged

SylvainJuge closed this Dec 8, 2021

APM-Agents (OLD) automation moved this from Blocked to Done Dec 8, 2021

SylvainJuge deleted the fix-few-java15-16-tests branch December 8, 2021 14:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

JDK 15+16 test fixes #2158

JDK 15+16 test fixes #2158

SylvainJuge commented Sep 28, 2021 •

edited

apmmachine commented Sep 28, 2021 •

edited

Build stats

Test stats 🧪

`Tests / Unit Tests / verifyThatTransactionWithSpanCreated – co.elastic.apm.agent.rabbitmq.AsyncRabbitListenerTest`

`Shell Script`

SylvainJuge commented Oct 11, 2021

eyalkoren Oct 11, 2021

eyalkoren commented Oct 11, 2021

SylvainJuge commented Oct 12, 2021

SylvainJuge commented Dec 8, 2021

JDK 15+16 test fixes #2158

JDK 15+16 test fixes #2158

Conversation

SylvainJuge commented Sep 28, 2021 • edited

apmmachine commented Sep 28, 2021 • edited

💔 Tests Failed

Build stats

Test stats 🧪

Test errors

Tests / Unit Tests / verifyThatTransactionWithSpanCreated – co.elastic.apm.agent.rabbitmq.AsyncRabbitListenerTest

Steps errors

Shell Script

🐛 Flaky test report

🤖 GitHub comments

SylvainJuge commented Oct 11, 2021

eyalkoren Oct 11, 2021

Choose a reason for hiding this comment

eyalkoren commented Oct 11, 2021

SylvainJuge commented Oct 12, 2021

SylvainJuge commented Dec 8, 2021

SylvainJuge commented Sep 28, 2021 •

edited

apmmachine commented Sep 28, 2021 •

edited

`Tests / Unit Tests / verifyThatTransactionWithSpanCreated – co.elastic.apm.agent.rabbitmq.AsyncRabbitListenerTest`

`Shell Script`