Add ignore_urls to central config

config.go

@@ -53,6 +53,8 @@ const (
 	envAPIBufferSize               = "ELASTIC_APM_API_BUFFER_SIZE"
 	envMetricsBufferSize           = "ELASTIC_APM_METRICS_BUFFER_SIZE"
 	envDisableMetrics              = "ELASTIC_APM_DISABLE_METRICS"
+	envIgnoreURLs                  = "ELASTIC_APM_TRANSACTION_IGNORE_URLS"
+	deprecatedEnvIgnoreURLs        = "ELASTIC_APM_IGNORE_URLS"
 	envGlobalLabels                = "ELASTIC_APM_GLOBAL_LABELS"
 	envStackTraceLimit             = "ELASTIC_APM_STACK_TRACE_LIMIT"
 	envCentralConfig               = "ELASTIC_APM_CENTRAL_CONFIG"
@@ -263,6 +265,14 @@ func initialDisabledMetrics() wildcard.Matchers {
 	return configutil.ParseWildcardPatternsEnv(envDisableMetrics, nil)
 }
 
+func initialIgnoreUrls() wildcard.Matchers {
+	matchers := configutil.ParseWildcardPatternsEnv(envIgnoreURLs, nil)
+	if len(matchers) == 0 {
+		matchers = configutil.ParseWildcardPatternsEnv(deprecatedEnvIgnoreURLs, nil)
+	}
+	return matchers
+}
+
 func initialStackTraceLimit() (int, error) {
 	value := os.Getenv(envStackTraceLimit)
 	if value == "" {
@@ -348,6 +358,11 @@ func (t *Tracer) updateRemoteConfig(logger WarningLogger, old, attrs map[string]
 					cfg.maxSpans = value
 				})
 			}
+		case envIgnoreURLs:
+			matchers := configutil.ParseWildcardPatterns(v)
+			updates = append(updates, func(cfg *instrumentationConfig) {
+				cfg.ignoreURLs = matchers
+			})
 		case envRecording:
 			recording, err := strconv.ParseBool(v)
 			if err != nil {
@@ -480,6 +495,11 @@ func (t *Tracer) updateInstrumentationConfig(f func(cfg *instrumentationConfig))
 	}
 }
 
+// GetIgnoreURLs returns the ignored URLs
+func (t *Tracer) GetIgnoreURLs() wildcard.Matchers {
+	return t.instrumentationConfig().ignoreURLs
+}
+
 // instrumentationConfig holds current configuration values, as well as information
 // required to revert from remote to local configuration.
 type instrumentationConfig struct {
@@ -510,4 +530,5 @@ type instrumentationConfigValues struct {
 	stackTraceLimit       int
 	propagateLegacyHeader bool
 	sanitizedFieldNames   wildcard.Matchers
+	ignoreURLs            wildcard.Matchers
 }

module/apmecho/middleware.go

@@ -41,7 +41,7 @@ import (
 func Middleware(o ...Option) echo.MiddlewareFunc {
 	opts := options{
 		tracer:         apm.DefaultTracer,
-		requestIgnorer: apmhttp.DefaultServerRequestIgnorer(),
+		requestIgnorer: apmhttp.DynamicServerRequestIgnorer(apm.DefaultTracer),
 	}
 	for _, o := range o {
 		o(&opts)

module/apmgin/middleware.go

@@ -47,7 +47,7 @@ func Middleware(engine *gin.Engine, o ...Option) gin.HandlerFunc {
 	m := &middleware{
 		engine:         engine,
 		tracer:         apm.DefaultTracer,
-		requestIgnorer: apmhttp.DefaultServerRequestIgnorer(),
+		requestIgnorer: apmhttp.DynamicServerRequestIgnorer(apm.DefaultTracer),
 	}
 	for _, o := range o {
 		o(m)

module/apmgorilla/middleware.go

@@ -77,7 +77,7 @@ func WrapMethodNotAllowedHandler(h http.Handler, m mux.MiddlewareFunc) http.Hand
 func Middleware(o ...Option) mux.MiddlewareFunc {
 	opts := options{
 		tracer:         apm.DefaultTracer,
-		requestIgnorer: apmhttp.DefaultServerRequestIgnorer(),
+		requestIgnorer: apmhttp.DynamicServerRequestIgnorer(apm.DefaultTracer),
 	}
 	for _, o := range o {
 		o(&opts)

module/apmhttp/handler.go

@@ -42,7 +42,7 @@ func Wrap(h http.Handler, o ...ServerOption) http.Handler {
 		handler:        h,
 		tracer:         apm.DefaultTracer,
 		requestName:    ServerRequestName,
-		requestIgnorer: DefaultServerRequestIgnorer(),
+		requestIgnorer: DynamicServerRequestIgnorer(apm.DefaultTracer),
 	}
 	for _, o := range o {
 		o(handler)

module/apmhttp/ignorer.go

@@ -22,6 +22,7 @@ import (
 	"regexp"
 	"sync"
 
+	"go.elastic.co/apm"
 	"go.elastic.co/apm/internal/configutil"
 	"go.elastic.co/apm/internal/wildcard"
 )
@@ -53,6 +54,16 @@ func DefaultServerRequestIgnorer() RequestIgnorerFunc {
 	return defaultServerRequestIgnorer
 }
 
+// DynamicServerRequestIgnorer returns the RequestIgnorer to use in
+// handlers. The list of wildcard patterns comes from central config
+func DynamicServerRequestIgnorer(t *apm.Tracer) RequestIgnorerFunc {
+	matchers := t.GetIgnoreURLs()
+	if len(matchers) != 0 {
+		defaultServerRequestIgnorer = NewWildcardPatternsRequestIgnorer(matchers)
+	}
+	return defaultServerRequestIgnorer
+}
+
 // NewRegexpRequestIgnorer returns a RequestIgnorerFunc which matches requests'
 // URLs against re. Note that for server requests, typically only Path and
 // possibly RawQuery will be set, so the regular expression should take this

module/apmhttprouter/handler.go

@@ -97,7 +97,7 @@ func wrapHandlerUnknownRoute(h http.Handler, o ...Option) http.Handler {
 func gatherOptions(o ...Option) options {
 	opts := options{
 		tracer:         apm.DefaultTracer,
-		requestIgnorer: apmhttp.DefaultServerRequestIgnorer(),
+		requestIgnorer: apmhttp.DynamicServerRequestIgnorer(apm.DefaultTracer),
 	}
 	for _, o := range o {
 		o(&opts)

module/apmrestful/filter.go

@@ -34,7 +34,7 @@ import (
 func Filter(o ...Option) restful.FilterFunction {
 	opts := options{
 		tracer:         apm.DefaultTracer,
-		requestIgnorer: apmhttp.DefaultServerRequestIgnorer(),
+		requestIgnorer: apmhttp.DynamicServerRequestIgnorer(apm.DefaultTracer),
 	}
 	for _, o := range o {
 		o(&opts)

tracer.go

@@ -103,6 +103,7 @@ type TracerOptions struct {
 	sampler               Sampler
 	sanitizedFieldNames   wildcard.Matchers
 	disabledMetrics       wildcard.Matchers
+	ignoreURLs            wildcard.Matchers
 	captureHeaders        bool
 	captureBody           CaptureBodyMode
 	spanFramesMinDuration time.Duration
@@ -246,6 +247,7 @@ func (opts *TracerOptions) initDefaults(continueOnError bool) error {
 	opts.sampler = sampler
 	opts.sanitizedFieldNames = initialSanitizedFieldNames()
 	opts.disabledMetrics = initialDisabledMetrics()
+	opts.ignoreURLs = initialIgnoreUrls()
 	opts.breakdownMetrics = breakdownMetricsEnabled
 	opts.captureHeaders = captureHeaders
 	opts.captureBody = captureBody