Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Record {transaction,sample}.sample_rate #804

Merged
merged 2 commits into from Sep 4, 2020
Merged

Record {transaction,sample}.sample_rate #804

merged 2 commits into from Sep 4, 2020

Commits on Sep 3, 2020

  1. Record {transaction,sample}.sample_rate 

    Introduce the new ExtendedSampler interface, which
Samplers may implement to return the effective
sampling rate. This is implemented by the built-in
ratioSampler.

When starting a root transaction we now call the
ExtendedSampler method if implemented, and store
the effective sampling rate in the transaction's
tracestate under our "es" vendor key.

When receiving tracestate, we parse our "es" vendor
value and extract the sample rate.

When encoding transactions and spans we record the
sample rate (from tracestate) in the transaction and
span events.
    @axw
    axw committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    2cf5ecd View commit details
    Browse the repository at this point in the history

  2. Improve test for special case

    @axw
    axw committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    690f23a View commit details
    Browse the repository at this point in the history