Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

module/apmot: fix nil-pointer deref in Inject #763

Merged
merged 2 commits into from May 6, 2020
Merged

module/apmot: fix nil-pointer deref in Inject #763

merged 2 commits into from May 6, 2020

Commits on May 6, 2020

  1. module/apmot: fix nil-pointer deref in Inject 

    If the SpanContext passed to Inject does not
contain a Transaction, then Inject would panic
due to a nil pointer dereference. We were using
the transaction to check if we should inject
the legacy header. Since this is not a dynamic
configuration, we can just use the tracer instead,
by adding a Tracer.ShouldPropagateLegacyHeader
method.
    @axw
    axw committed May 6, 2020
    Configuration menu
    Copy the full SHA
    331fa03 View commit details
    Browse the repository at this point in the history

  2. Update changelog

    @axw
    axw committed May 6, 2020
    Configuration menu
    Copy the full SHA
    5991ff8 View commit details
    Browse the repository at this point in the history