New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[apmfasthttp] fix: set response context with closer close #1193
Conversation
Can you add a test to verify the fixed behavior? |
The test added in #1104 tests the same case! https://github.com/elastic/apm-agent-go/blob/master/module/apmfasthttp/server_test.go#L36 |
@savsgio the test you reference was succeeding without your change. Please add a test which would fail without your change, and succeeds with your change. |
@axw could you review it again?, please! |
Thanks @savsgio, I will take a look soon. We have a few other things going on too, so it may take a little while. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes! Looks good apart from the couple of comments I've left.
@axw Could you review it again? please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay, LGTM. Thanks!
/test |
@savsgio CI is unhappy:
Please run |
@savsgio the change has broken the apmfiber tests. Can you please take a look at those? |
/run elasticsearch-ci/docs |
Thanks @savsgio! |
Thank you so much @axw! |
Fix and set correctly the response context data to the apm transacction after the request finish (included Hijack and Stream connections).
Relationed issue: #1104
Fasthttp issues: valyala/fasthttp#1176, valyala/fasthttp#1199