module/apmot: fix nil-pointer deref in Inject #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the SpanContext passed to Inject does not contain a Transaction, then Inject would panic due to a nil pointer dereference. We were using the transaction to check if we should inject the legacy header. Since this is not a dynamic configuration, we can just use the tracer instead, by adding a Tracer.ShouldPropagateLegacyHeader method.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
Codecov Report
@@ Coverage Diff @@
## master #763 +/- ##
==========================================
+ Coverage 84.68% 84.71% +0.02%
==========================================
Files 127 127
Lines 8384 8385 +1
==========================================
+ Hits 7100 7103 +3
+ Misses 899 898 -1
+ Partials 385 384 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the SpanContext passed to Inject does not contain a Transaction, then Inject would panic due to a nil pointer dereference. Transaction will always be nil in the result of Extract, and will only be set when creating a new span with the context.
We were using the transaction to check if we should inject the legacy header. Since this is not a dynamic configuration setting, we can just use the tracer instead, by adding a
tracer.ShouldPropagateLegacyHeadermethod.Fixes #761
Supersedes #762