Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade spf13/cobra to v1.1.1 to fix zsh completion issue #2813

Merged
merged 3 commits into from Nov 12, 2020
Merged

Upgrade spf13/cobra to v1.1.1 to fix zsh completion issue #2813

merged 3 commits into from Nov 12, 2020

Conversation

ysam12345
Copy link
Contributor

Description

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

michaelbeaumont
michaelbeaumont approved these changes Nov 12, 2020
View reviewed changes
Copy link
Contributor

@michaelbeaumont michaelbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go in, we should refactor these tests (see #2747 (comment))

@weaveworksbot weaveworksbot merged commit 285f53e into eksctl-io:master Nov 12, 2020
@michaelbeaumont
Copy link
Contributor

Thanks @ysam12345 !

@ysam12345
Copy link
Contributor Author

@michaelbeaumont I’m happy to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelbeaumont michaelbeaumont michaelbeaumont approved these changes

Assignees
No one assigned
Labels
kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zsh autocomplete error when calling eksctl create nodegroup - invalid option definition
3 participants
@ysam12345 @michaelbeaumont @weaveworksbot