Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade spf13/cobra to v1.1.0 to fix zsh completion issue #2756

Closed
wants to merge 1 commit into from

Conversation

ysam12345
Copy link
Contributor

Description

Upgrade version of spf13/cobra from v1.0.0 to v1.1.0 to fix #2747

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont
Copy link
Contributor

Thanks!

@michaelbeaumont
Copy link
Contributor

It looks like the tests that check CLI output are failing. This is likely because the output has changed somehow between versions

@ysam12345
Copy link
Contributor Author

It looks like the tests that check CLI output are failing. This is likely because the output has changed somehow between versions

Ok, I'll look into it.

@ysam12345
Copy link
Contributor Author

@michaelbeaumont I found that is because RP spf13/cobra#894 changed some error output from stdOut to stdErr, so some of our test cases failed. I can fix it by adding stdErr to our output buffer, and all the test cases passed.
image
But I don't think this is the best practice, so I'll take some time to rewrite some code of unit test to fit the new spf13/cobra module.

@ysam12345
Copy link
Contributor Author

Need more discuss in #2747.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

zsh autocomplete error when calling eksctl create nodegroup - invalid option definition
2 participants