-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add completion support for fish #2025
Conversation
6b361cf
to
abca1be
Compare
abca1be
to
2864854
Compare
@@ -37,7 +37,7 @@ require ( | |||
github.com/pkg/errors v0.9.1 | |||
github.com/riywo/loginshell v0.0.0-20190610082906-2ed199a032f6 | |||
github.com/spf13/afero v1.2.2 | |||
github.com/spf13/cobra v0.0.6 | |||
github.com/spf13/cobra v1.0.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/spf13/cobra/releases/tag/v1.0.0 just released today 🎉
@@ -26,7 +24,7 @@ If you are stuck on Bash 3 (macOS) use | |||
source /dev/stdin <<<"$(eksctl completion bash)" | |||
`, | |||
RunE: func(cmd *cobra.Command, args []string) error { | |||
return rootCmd.GenBashCompletion(os.Stdout) | |||
return rootCmd.GenBashCompletion(cmd.OutOrStdout()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use output from cmd for testability
bebd5db
to
41bbd5d
Compare
Add missing unit test for completion CLI Update shell installation docs
41bbd5d
to
ed3e7bc
Compare
@martina-if @cPu1 your review is highly appreciated 👍 |
Description
Fixes #1496
Checklist
README.md
, or thesite/content
directory)area/nodegroup
), target version (e.g.version/0.12.0
) and kind (e.g.kind/improvement
)