Make ExtendedNode and Label public again (typetools#6130)

In typetools#5955, the `ExtendedNode` and `Label` classes from the dataflow framework were changed from public to package-private. However, NullAway relies on these classes being public (see typetools#5156, typetools#5152, and uber/NullAway#608). This PR makes the classes public again and adds an explanatory comment.
eisop · Oct 16, 2023 · 7b5be5d · 7b5be5d
1 parent bd70f73
commit 7b5be5d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/dataflow/src/main/java/org/checkerframework/dataflow/cfg/builder/ExtendedNode.java b/dataflow/src/main/java/org/checkerframework/dataflow/cfg/builder/ExtendedNode.java
@@ -18,6 +18,9 @@
  *   <li><em>TWO_TARGET_CONDITIONAL_JUMP</em>: {@link ConditionalJump}. A conditional jump with two
  *       targets for both the 'then' and 'else' branch.
  * </ul>
+ *
+ * Note that this class is deliberately public, to enable users of the dataflow library to customize
+ * CFG construction.
  */
 @SuppressWarnings("nullness") // TODO
 public abstract class ExtendedNode {

diff --git a/dataflow/src/main/java/org/checkerframework/dataflow/cfg/builder/Label.java b/dataflow/src/main/java/org/checkerframework/dataflow/cfg/builder/Label.java
@@ -4,6 +4,9 @@
  * A label is used to refer to other extended nodes using a mapping from labels to extended nodes.
  * Labels get their names either from labeled statements in the source code or from internally
  * generated unique names.
+ *
+ * <p>Note that this class is deliberately public, to enable users of the dataflow library to
+ * customize CFG construction.
  */
 public class Label {