Resource Leak Checker: Add a check to avoid mapping multiple keys to …

…a ternary expression for tempVarToTree (typetools#5137)

checker/src/main/java/org/checkerframework/checker/resourceleak/ResourceLeakAnnotatedTypeFactory.java

@@ -233,7 +233,9 @@ protected ResourceLeakAnalysis createFlowAnalysis() {
    * @param tree the tree of the expression the tempvar represents
    */
   /* package-private */ void addTempVar(LocalVariableNode tmpVar, Tree tree) {
-    tempVarToTree.put(tmpVar, tree);
+    if (!tempVarToTree.containsValue(tree)) {
+      tempVarToTree.put(tmpVar, tree);
+    }
   }
 
   /**

checker/tests/resourceleak/HDFSReport.java

@@ -0,0 +1,24 @@
+class Handler extends Thread {
+  boolean running;
+
+  static class Call {
+    boolean isResponseDeferred() {
+      return true;
+    }
+  }
+
+  @Override
+  public void run() {
+    while (running) {
+      Call call = null;
+      try {
+        if (running) {
+          continue;
+        }
+      } catch (Exception e) {
+      } finally {
+        String s = call.isResponseDeferred() ? ", deferred" : "";
+      }
+    }
+  }
+}