Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add m2e support for npm, npx and yarn goals #955

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

zraexy
Copy link

@zraexy zraexy commented Feb 1, 2021

Summary

Adds support for running scripts when source files change without having to bump the package.json

My specific use case is automatically rebuilding an Angular frontend when its source is modified.

Theoretically the common functionality between EmberMojo, GruntMojo, GulpMojo, NpmMojo, NpxMojo, WebpackMojo, and YarnMojo could be factored out into a new class, but for now I've only endeavored to make their behavior consistent.

Resolves #932
Fixes #329, Closes #682 (included)

Tests and Documentation

Tests passed. (Not that there is coverage anyway.)

Updated CHANGELOG.md and README.md
I can update the Wiki on merge.

@OLibutzki
Copy link

@zraexy thanks for providing this PR. What about the failed check?

@zraexy
Copy link
Author

zraexy commented Feb 12, 2021

@zraexy thanks for providing this PR. What about the failed check?

It is a known issue with maven-plugin-plugin 3.2 which was fixed in 3.2.2. For whatever reason 3.2.2 doesn't appear to be in Maven Central. I'm not sure why this is only now presenting. I've made a few tweaks and added a commit bumping it to 3.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add m2e support for npm and yarn goals <triggerfile>
2 participants