Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression when extracting tar archive to a path containig a symlink #864

Merged
merged 3 commits into from Dec 17, 2019
Merged

Fix regression when extracting tar archive to a path containig a symlink #864

merged 3 commits into from Dec 17, 2019

Commits on Dec 5, 2019

  1. Add unit tests for DefaultArchiveExtractor 

    * test extraction of malicious tar files
* test extraction of a tar file into path with a symlink
  (this is a test for the fix in commit 6175368)
    @arminha
    arminha committed Dec 5, 2019
    Copy the full SHA
    a1be747 View commit details
    Browse the repository at this point in the history

  2. Fix a regression in ArchiveExtractor that causes it to fail when extr… 

    …acting to a path containig a symlink

This fixes a regression that was originaly fixed in commit 6175368 but reintroduced in commit 5a5eb07.
    @arminha
    arminha committed Dec 5, 2019
    Copy the full SHA
    605672b View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. DefaultArchiveExtractorTest shouldn't fail when symlinks cannot be cr… 

    …eated

Files.createSymbolicLink can also fail with an IOException when the user doesn't have the rights to create a symlink. For example on Windows 10 as normal user withouth admin rights.
    @arminha
    arminha committed Dec 6, 2019
    Copy the full SHA
    dea2086 View commit details
    Browse the repository at this point in the history