#41 Replaced ProcessBuilder usage with commons-exec #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there anything else this PR needs in order to get merged? |
|
I'm waiting for travis results. Is it possible to trigger it again? |
|
Looks OK now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a rebase of the PR submitted for this previously ( #345 ) with merge conflicts resolved. This fixes #41
The previous summary still applies:
By using commons-exec instead of plain ProcessBuilder we can support killing the Node process if the Maven build is stopped (via ShutdownHookProcessDestroyer). An optional timeout (which leverages ExecuteWatchdog) can be specified (not exposed to the task runners yet).
With commons-exec we get quote handling and variable substitution in arguments for free (via CommandLine.addArgument()).
A workaround for #343 is implemented as well.