Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sgtrivy): update misconfig-scanners #539

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix(sgtrivy): update misconfig-scanners #539

merged 1 commit into from
Apr 9, 2024

Conversation

thall
Copy link
Member

@thall thall commented Apr 9, 2024

Trivy has added support for scanning terraform plan snapshots and
thus so updated the config names.

See PR

Fixes error:

[terraform:security-check] 2024-04-09T09:37:47.378Z	INFO	Misconfiguration scanning is enabled
[terraform:security-check] 2024-04-09T09:37:47.378Z	INFO	Need to update the built-in policies
[terraform:security-check] 2024-04-09T09:37:47.378Z	INFO	Downloading the built-in policies...
[terraform:security-check] 46.13 KiB / 46.13 KiB [-----------------------------------------------------------] 100.00% ? p/s 0s
[terraform:security-check] 2024-04-09T09:37:47.570Z	ERROR	Invalid misconfig scanners specified: [terraform terraformplan] defaulting to use all misconfig scanners
[terraform:security-check] 2024-04-09T09:37:50.125Z	INFO	Detected config files: 4
$ ../.sage/bin/trivy config --help
...
Misconfiguration Flags
      --misconfig-scanners strings        comma-separated list of misconfig scanners to use for misconfiguration scanning (default [azure-arm,cloudformation,dockerfile,helm,kubernetes,terraform,terraformplan-json,terraformplan-snapshot])
...

@thall thall requested a review from a team as a code owner April 9, 2024 10:02
Trivy has added support for scanning terraform plan snapshots and
thus so updated the config names.

See [PR](aquasecurity/trivy#6176)
Copy link
Collaborator

@alethenorio alethenorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thall Don't we need to bump the trivy version?

@thall
Copy link
Member Author

thall commented Apr 9, 2024

@thall Don't we need to bump the trivy version?

@odsod did so, 154b169

@thall
Copy link
Member Author

thall commented Apr 9, 2024

Failing here when bumping sage

@alethenorio
Copy link
Collaborator

Ah looks like it was missed in the bump. Got it

@thall thall merged commit d3f1a92 into master Apr 9, 2024
3 checks passed
@thall thall deleted the fix-trivy branch April 9, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants