Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use git root dir for .tools #37

Merged
merged 1 commit into from Dec 23, 2021
Merged

fix: use git root dir for .tools #37

merged 1 commit into from Dec 23, 2021

Conversation

viktorvoltaire
Copy link
Contributor

@viktorvoltaire viktorvoltaire commented Dec 23, 2021 •
edited

Instead of creating .tools in every folder we run mage from, we store everything in the git root directory

Edholm
Edholm approved these changes Dec 23, 2021
View reviewed changes
Copy link
Member

@Edholm Edholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice! I read this thinking we started storing .tools in the .git folder but I see now that it relative to the repo root 👍

alethenorio
alethenorio approved these changes Dec 23, 2021
View reviewed changes
Copy link
Collaborator

@alethenorio alethenorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@viktorvoltaire viktorvoltaire merged commit 6a983e9 into main Dec 23, 2021
@viktorvoltaire viktorvoltaire deleted the only_store_tools_in_repo_root branch December 23, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Edholm Edholm Edholm approved these changes

@alethenorio alethenorio alethenorio approved these changes

@odsod odsod Awaiting requested review from odsod

@thall thall Awaiting requested review from thall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viktorvoltaire @Edholm @alethenorio