fix: downgrade opentelemetry-operations-go to 0.34.1 #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as we see memory leak type of issue and a constant increase of bytes to google with updated version of opentelemetry-operations-go
liufuyang
commented
Feb 14, 2023
| @@ -40,8 +40,8 @@ require ( | |||
| cloud.google.com/go/compute v1.18.0 // indirect | |||
| cloud.google.com/go/monitoring v1.12.0 // indirect | |||
| cloud.google.com/go/trace v1.8.0 // indirect | |||
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.11.1 // indirect | |||
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/internal/resourcemapping v0.35.1 // indirect | |||
| github.com/GoogleCloudPlatform/opentelemetry-operations-go/detectors/gcp v1.11.0 // indirect | |||
There was a problem hiding this comment.
Tried to put this to 1.10.1 but go mod tidy updates it.
|
Some other packages needed to downgrade as well to fix build error: |
liufuyang
force-pushed
the
downgrade-opentelemetry-operations-go
branch
from
8db1446
to
afd72a6
Compare
|
Cant we just revert #382 ? |
|
I think its easier just revert the whole PR rather than trying to cherry-pick stuff from it. |
|
Tried to revert one by one from the end but got some conflicts... Will not touch it for now, and feel free to make another PR on your side to fix it if you find a good/easy way to revert those commits back :) |
ericwenn
approved these changes
Feb 15, 2023
|
We can try update again when this GoogleCloudPlatform/opentelemetry-operations-go#591 is merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we see memory leak type of issue and a constant increase of bytes to google with updated version of opentelemetry-operations-go.
This reverts some of the changes made here #382
The issue seen from a backend service could be like:
vehicle-service
own-service
vehicle-service CPU profile
https://console.cloud.google.com/profiler;timespan=1h;end=2023-02-14T11:30:00.000Z/vehicle-eu/cpu?project=e-vehicle-service-prod&pli=1
Also could see the backend service's metric will break when updated...
