Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade deps to enable postcss 8 #335

Closed
wants to merge 1 commit into from
Closed

Conversation

isaacl
Copy link

@isaacl isaacl commented Nov 7, 2020

Fixes #324

@codecov
Copy link

codecov bot commented Nov 7, 2020

Codecov Report

Merging #335 (9d0a3e2) into master (661c9ca) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #335   +/-   ##
=======================================
  Coverage   92.68%   92.68%           
=======================================
  Files          10       10           
  Lines         328      328           
  Branches      115      115           
=======================================
  Hits          304      304           
  Misses         23       23           
  Partials        1        1           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 661c9ca...9d0a3e2. Read the comment docs.

@ai
Copy link

ai commented Nov 7, 2020

LGTM

@softbeehive
Copy link

Hey folks, is there a blocker? I wonder why it hasn't been approved yet

@@ -1,6 +1,6 @@
{
"name": "rollup-plugin-postcss",
"version": "3.0.0",
"version": "3.1.8",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need to bump version manually? 3.1.8 was published in August, I assume next release including these changes will actually have a different version

@spacedawwwg
Copy link

Good to see this one go in

@danielbarion
Copy link

I'm very excited and waiting for this PR, nice!

@SASUKE40
Copy link
Collaborator

SASUKE40 commented Dec 6, 2020

Is this PR a duplicate of the previous one ?
#325

@ai
Copy link

ai commented Dec 6, 2020

It is an improvement for #325

We need to update postcss-load-config to be able to load PostCSS 8 plugins.

@SASUKE40
Copy link
Collaborator

SASUKE40 commented Dec 6, 2020

I upgraded it in another pr, and migrated the noop postcss plug-in.

@wardpeet
Copy link
Collaborator

wardpeet commented Dec 6, 2020

Thanks for your PR and sorry for the delay, it seems that #342 already fixes this.

@wardpeet wardpeet closed this Dec 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PostCSS 8
7 participants