New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade deps to enable postcss 8 #335
Conversation
Codecov Report
@@ Coverage Diff @@
## master #335 +/- ##
=======================================
Coverage 92.68% 92.68%
=======================================
Files 10 10
Lines 328 328
Branches 115 115
=======================================
Hits 304 304
Misses 23 23
Partials 1 1 Continue to review full report at Codecov.
|
LGTM |
Hey folks, is there a blocker? I wonder why it hasn't been approved yet |
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "rollup-plugin-postcss", | |||
"version": "3.0.0", | |||
"version": "3.1.8", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you need to bump version manually? 3.1.8 was published in August, I assume next release including these changes will actually have a different version
Good to see this one go in |
I'm very excited and waiting for this PR, nice! |
Is this PR a duplicate of the previous one ? |
It is an improvement for #325 We need to update |
I upgraded it in another pr, and migrated the noop postcss plug-in. |
Thanks for your PR and sorry for the delay, it seems that #342 already fixes this. |
Fixes #324