Add augmentChunkHash hook for proper content hashing #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #231 +/- ##
==========================================
+ Coverage 91.75% 92.54% +0.78%
==========================================
Files 9 9
Lines 291 295 +4
Branches 102 103 +1
==========================================
+ Hits 267 273 +6
+ Misses 24 22 -2
Continue to review full report at Codecov.
|
Enables rollup to properly use processed css result for content hashing
|
Possible to take a look at this? @himself65 @SASUKE40 |
himself65
approved these changes
Mar 2, 2020
|
thanks for your contributions🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables rollup to properly use the processed css result for content hashing through
[hash]withextract: true.augmentChunkHashallows plugins to provide content to be used for rollups hashing function, and this PR passes on a stringified version of the extracted result. Making content from sass@imports etc included in the hashing. Ref rollup/rollup#2921The reduce logic is basically just to parse the
extractedMap to an object that contains the key-value pairs.