New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generateBundle
instead of onwrite
#148
Conversation
Fixes #147 The `onwrite` rollup hook has been deprecated in favor of `generateBundle`. rollup/rollup#2409
Can you update the snapshots in the tests? |
@nathancahill hey, I did but something doesn't look ok, and the order of the css rules aren't deterministic. (no matter if I update the snapshots or not, it fails) I'll have to investigate a bit more. |
PR #143 should fix the order of css rules, and make the order deterministics. However, with the new
should become:
|
Codecov Report
@@ Coverage Diff @@
## master #148 +/- ##
==========================================
+ Coverage 94.61% 94.69% +0.07%
==========================================
Files 8 8
Lines 223 226 +3
Branches 77 79 +2
==========================================
+ Hits 211 214 +3
Misses 12 12
Continue to review full report at Codecov.
|
Thanks @kendrickw I fixed the module order in the PR. |
@egoist @lmihaidaniel Fixes egoist#147 The `onwrite` rollup hook has been deprecated in favor of `generateBundle` in `rollup@1.x.x`. rollup/rollup#2409
@egoist @lmihaidaniel
Fixes #147
The
onwrite
rollup hook has been deprecated in favor ofgenerateBundle
inrollup@1.x.x
. rollup/rollup#2409