Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ensure filename for esm format #364

Merged
merged 2 commits into from Jun 21, 2020
Merged

fix: ensure filename for esm format #364

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7cbb4a9
ensure filename for esm format
egoist Jun 21, 2020
2c23351
no dot
egoist Jun 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/index.ts
View file
Open in desktop
Expand Up @@ -457,12 +457,16 @@ export class Bundler {
typeof getFileName === 'function'
? getFileName({ format: rollupFormat, minify }, defaultFileName)
: getFileName
const fileName = fileNameTemplate
let fileName = fileNameTemplate
.replace(/\[min\]/, minPlaceholder)
// The `[ext]` placeholder no longer makes sense
// Since we only output to `.js` now
// Probably remove it in the future
.replace(/\[ext\]/, '.js')

if (rollupFormat === 'esm') {
egoist marked this conversation as resolved.
Show resolved Hide resolved
fileName = fileName.replace(/\[format\]/, 'esm')
}

return {
inputConfig: {
Expand Down