Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade rollup plugins #263

Closed
wants to merge 5 commits into from
Closed

Conversation

vladimyr
Copy link

This PR swaps deprecated plugins with new official variants:

  1. rollup-plugin-buble => @rolllup/plugin-buble
  2. rollup-plugin-json => @rollup/plugin-json

This is stacked onto #259

@codecov
Copy link

codecov bot commented Nov 14, 2019

Codecov Report

Merging #263 into master will increase coverage by 0.4%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #263     +/-   ##
========================================
+ Coverage      75%   75.4%   +0.4%     
========================================
  Files          11      12      +1     
  Lines         420     427      +7     
  Branches      158     156      -2     
========================================
+ Hits          315     322      +7     
  Misses        100     100             
  Partials        5       5
Impacted Files Coverage Δ
src/index.ts 71.84% <100%> (+0.2%) ⬆️
src/utils/normalize-plugin-name.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3f1be7...f22132d. Read the comment docs.

Swap `rollup-plugin-buble` & `rollup-plugin-json` with new
`@rollup/plugin-buble` & `@rollup/plugin-json`.
@vladimyr
Copy link
Author

@fi3ework Hm, care to share why did you close it?

@fi3ework
Copy link
Collaborator

@vladimyr Hi, this PR bumps @rolllup/plugin-buble and @rollup/plugin-json. These two plugins had been upgraded in #357. And #259 is still opened.

@vladimyr
Copy link
Author

Ah missed that bit, thanks for the explanation 👍, hopefully, #259 lands soon.

@fi3ework
Copy link
Collaborator

fi3ework commented Jun 19, 2020

@vladimyr My bad, I should close it with leaving a reason 😅.

@vladimyr
Copy link
Author

Kill it with fire if you like 😛 I was just interested in giving some love to this awesome project which is by far the best rollup wrapper out there. Seeing someone else, actually, the man himself did it still warms my heart 😉

@vladimyr vladimyr deleted the update-plugins branch June 19, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants