fix: ensure filename for esm format #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/egoist/bili/75a3iilfn |
Codecov Report
@@ Coverage Diff @@
## master #364 +/- ##
==========================================
- Coverage 75.33% 75.21% -0.12%
==========================================
Files 11 11
Lines 454 456 +2
Branches 168 169 +1
==========================================
+ Hits 342 343 +1
- Misses 107 108 +1
Partials 5 5
Continue to review full report at Codecov.
|
fi3ework
reviewed
Jun 21, 2020
src/index.ts
Outdated
| .replace(/\[min\]/, minPlaceholder) | ||
| // The `[ext]` placeholder no longer makes sense | ||
| // Since we only output to `.js` now | ||
| // Probably remove it in the future | ||
| .replace(/\[ext\]/, '.js') | ||
|
|
||
| if (rollupFormat === 'esm') { | ||
| fileName = fileName.replace(/\[format\]/, '.esm') |
There was a problem hiding this comment.
Suggested change
| fileName = fileName.replace(/\[format\]/, '.esm') | |
| fileName = fileName.replace(/\[format\]/, 'esm') |
fi3ework
reviewed
Jun 21, 2020
|
🎉 This PR is included in version 5.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
chocolateboy
added a commit
to chocolateboy/conjoin
that referenced
this pull request
Jun 23, 2020
chocolateboy
added a commit
to chocolateboy/conjoin
that referenced
this pull request
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix regression for #363, closes #363