Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Adding rollup-plugin-vue now requires inline-bundle of rollup-plugin-commonjs when generating esm? #221

Open
xaksis opened this issue Jul 9, 2019 · 4 comments · May be fixed by #507

Comments

@xaksis
Copy link

xaksis commented Jul 9, 2019

Adding rollup-plugin-vue now requires including rollup-plugin-commonjs:
https://github.com/vuejs/rollup-plugin-vue#usage

This adds an inline dependency in esm files:
import __vue_normalize__ from 'vue-runtime-helpers/dist/normalize-component.js';

does this mean we'll have to use --bundleNodeModules?

@jofftiquez
Copy link

Same question.

@LeCoupa
Copy link
Contributor

LeCoupa commented Nov 4, 2019

I get the same issue

@hosein2398
Copy link
Contributor

This is related to rollup-plugin-vue rather Bili, But using --bundle-node-modules seems to fix this for now.
Just consider that this will include all of your imports in bundle, not only this one.

@bodograumann
Copy link

In the rollup-plugin-vue docs, I could not find any information regarding this. The author explains it here though: vuejs/rollup-plugin-vue#308 (comment)

Given that bili wants to be “ridiculously easy”, I think it should provide sensible defaults here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants