Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue-runtime-helpers/dist/normalize-component.js not found - 2.17.0 #569

Open
1 task done
chasegiunta opened this issue Jul 6, 2019 · 29 comments
Open
1 task done

Comments

@chasegiunta
Copy link

Issue Type

  • Bug

Specs

What version are you using?
2.17.0

Technically 2.17.0 doesn't seem to be released yet, but dependabot flagged the updated dependency for me, so it might've for others as well - so I'll just let you know anyways.

After updating, build/dev server fails on 2.17.0

This dependency was not found:

* vue-runtime-helpers/dist/normalize-component.js in ./node_modules/vue-good-table/dist/vue-good-table.esm.js

To install it, you can run: npm install --save vue-runtime-helpers/dist/normalize-component.js

I couldn't manually install vue-runtime-helpers/dist/normalize-component.js either - returned 405 error...

Downgrading to 2.16.5 fixes for now!

@xaksis
Copy link
Owner

xaksis commented Jul 6, 2019

looks like an error in rollup plugin
vuejs/rollup-plugin-vue#257
I updated the dependency. Thank you for bringing this up.

@xaksis xaksis closed this as completed Jul 6, 2019
@stefanwuthrich
Copy link

@xaksis I had the same problem, after upgrade to 2.7.1 I get the same error as before "fix".

@stefanwuthrich
Copy link

@chasegiunta can you confirm that it is fixed for you ih 2.7.1 ? (as for me it is not)

@ekrist1
Copy link

ekrist1 commented Jul 8, 2019

I got the same problem with 2.7.1 running npm run dev (Laravel + Vue installation):
Module not found: Error: Can't resolve 'vue-runtime-helpers/dist/normalize-component.js' in '/Users/myuser/Code/hvaskjer/node_modules/vue-good-table/dist'

@xaksis
Copy link
Owner

xaksis commented Jul 8, 2019

Going to reopen this to investigate

@xaksis xaksis reopened this Jul 8, 2019
@xaksis xaksis closed this as completed in 1882c17 Jul 8, 2019
@xaksis
Copy link
Owner

xaksis commented Jul 8, 2019

@rakk7
Copy link

rakk7 commented Jul 9, 2019

still having the same issue for version 2.17.2 when using npm

@ccclin
Copy link

ccclin commented Jul 9, 2019

One of workaround is add devDependencies into package.json
like:

"devDependencies": {
    ...
    "rollup-plugin-commonjs": "^10.0.1",
    "rollup-plugin-vue": "^5.0.1",
    ...
}

@rashed50702
Copy link

One of workaround is add devDependencies into package.json
like:

"devDependencies": {
    ...
    "rollup-plugin-commonjs": "^10.0.1",
    "rollup-plugin-vue": "^5.0.1",
    ...
}

Still it's not working !!

@ccclin
Copy link

ccclin commented Jul 9, 2019

One of workaround is add devDependencies into package.json
like:

"devDependencies": {
    ...
    "rollup-plugin-commonjs": "^10.0.1",
    "rollup-plugin-vue": "^5.0.1",
    ...
}

Still it's not working !!

It works for my project and I am not sure if need to install additional dependencies.

@xaksis
Copy link
Owner

xaksis commented Jul 9, 2019

darn! these dependency issues will be the end of me... specially because i'm having trouble reproducing this on my end. re-opening.

@xaksis xaksis reopened this Jul 9, 2019
@xaksis
Copy link
Owner

xaksis commented Jul 9, 2019

same as #571

@xaksis
Copy link
Owner

xaksis commented Jul 9, 2019

Let's see what egoist suggests: egoist/bili#221

@controljud
Copy link

One of workaround is add devDependencies into package.json
like:

"devDependencies": {
    ...
    "rollup-plugin-commonjs": "^10.0.1",
    "rollup-plugin-vue": "^5.0.1",
    ...
}

Same problem, but this works for me
Thanks

@ashniazi
Copy link

"rollup-plugin-commonjs": "^10.0.1",
"rollup-plugin-vue": "^5.0.1",

Can confirm this fixed my problem too.

@clouedoc
Copy link

yarn user here
following @ccclin's solution, deleting node_modules and operating a fresh yarn install solved the problem.
thanks

@gabrieldarezzo
Copy link

Same issue here:

This dependency was not found:

* vue-runtime-helpers/dist/normalize-component.js in ./node_modules/vue-good-table/dist/vue-good-table.esm.js

To install it, you can run: npm install --save vue-runtime-helpers/dist/normalize-component.js

This just happen after run:
npm update

I checked my package-lock.json
"vue-good-table": "2.17.2"

I just rollback to:

...
"dependencies": {
  "vue-good-table": "2.16.5",
}
...

Run:
npm install

And everthing works again ^^

@mesqueeb
Copy link

mesqueeb commented Jul 15, 2019

Same problem here.
Not using Rollup, only webpack.

It works if I hard-code the version via:

npm i vue-good-table@2.16.5

@xaksis
Copy link
Owner

xaksis commented Jul 15, 2019

Yes, please continue to use 2.16.5 for now. I'll update once I have a good solution for the rollup changes.

@jorodriguez
Copy link

jorodriguez commented Jul 15, 2019

Solved with,

paste two lines,

"rollup-plugin-commonjs": "^ 10.0.1",
"rollup-plugin-vue": "^ 5.0.1",

and npm install.

tank's

@comhernandez28
Copy link

I had this exact problem in in an Installation of Laravel 5.8.28/Vue 2.6.10
I did not have rollup installed so I'm not sure of what the cause is but I just ended up changing the import to this
import VueGoodTable from 'vue-good-table/dist/vue-good-table.js';
Which ended up working.
Not sure if this is a proper fix though.

@xaksis
Copy link
Owner

xaksis commented Jul 17, 2019

@comhernandez28 yeah, the issue is only with the esm file that is created. umd and cjs versions should work fine.

@xaksis
Copy link
Owner

xaksis commented Jul 17, 2019

inlining the missing dependency in 2.17.3. This should fix the not found issue.

@chasegiunta
Copy link
Author

chasegiunta commented Jul 17, 2019

@xaksis working on my end 👍- but I'll leave to you to close if you want to hear from others. Appreciate your hard work!

@mesqueeb
Copy link

Does "inlining" mean the library grew in size?

@zcuric
Copy link

zcuric commented Aug 7, 2019

@xaksis Hi, I have the same issue on my component for Plyr (zcuric/plyrue#5).

Your solution to bundle node modules with bili ended up increasing the size of bundle for vue-good-table. Comparison can be made here on unpkg or on bundlephobia.

I suggest doing what I did, until proper solution has been found, lock rollup-plugin-vue to 4.3.2. You'll keep your build smaller.

I'll try to fix this in a better way and inform you if I found anything. Cheers.

@LeCoupa
Copy link

LeCoupa commented Nov 4, 2019

@zcuric did you find a better way than downgrading to 4.3.2?

@zcuric
Copy link

zcuric commented Nov 4, 2019

@LeCoupa To be honest, I didn't look for it, didn't have time. I'll will take a look in the nearby future.

@LeCoupa
Copy link

LeCoupa commented Nov 4, 2019

@zcuric I ended up using vue-sfc-rollup. It made the process of bundling components way simpler.

https://github.com/team-innovation/vue-sfc-rollup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests